Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(db): make to allow to show/hide the password when only creating #20186

Merged
merged 1 commit into from
May 26, 2022
Merged

fix(db): make to allow to show/hide the password when only creating #20186

merged 1 commit into from
May 26, 2022

Conversation

prosdev0107
Copy link
Contributor

@prosdev0107 prosdev0107 commented May 25, 2022 •
edited
Loading

SUMMARY

Show/Hide Password in Database Connection Creation Dynamic Forms

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
image

AFTER:
image

TESTING INSTRUCTIONS

How to reproduce issues

  1. By default, anything typed in the password field should be masked
  2. User should be able to toggle to see the password and toggle back to hiding the password ONLY WHEN entering the password when CONNECTING a database, not when EDITING one
  3. When editing an existing db connection the password should be masked WITHOUT the option to show the password to prevent unintentionally showing passwords to someone who didn't initially connect the db
  4. See details in comment on show/hide icon and tooltip text

The relevant forms that this should impact:
Postgres
MySQL
Snowflake
Redshift

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #20186 (370be43) into master (ce01ce9) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #20186      +/-   ##
==========================================
- Coverage   66.44%   66.42%   -0.03%     
==========================================
  Files        1721     1721              
  Lines       64548    64581      +33     
  Branches     6811     6821      +10     
==========================================
+ Hits        42890    42899       +9     
- Misses      19925    19949      +24     
  Partials     1733     1733
Flag Coverage Δ
javascript 51.29% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eModal/DatabaseConnectionForm/CommonParameters.tsx 90.00% <ø> (+4.28%) ⬆️
...et-frontend/src/components/EditableTitle/index.tsx 64.28% <0.00%> (-5.72%) ⬇️
.../components/Header/HeaderActionsDropdown/index.jsx 68.33% <0.00%> (-3.34%) ⬇️
...ins/plugin-chart-table/src/DataTable/DataTable.tsx 35.39% <0.00%> (-3.15%) ⬇️
...ponents/ReportModal/HeaderReportDropdown/index.tsx 68.00% <0.00%> (-1.34%) ⬇️
.../explore/components/ExploreViewContainer/index.jsx 52.02% <0.00%> (-0.55%) ⬇️
...tend/plugins/plugin-chart-table/src/TableChart.tsx 38.77% <0.00%> (-0.24%) ⬇️
superset-frontend/src/components/Icons/index.tsx 100.00% <0.00%> (ø)
...end/src/components/PageHeaderWithActions/index.tsx 90.00% <0.00%> (ø)
...nd/plugins/plugin-chart-table/src/controlPanel.tsx 16.66% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce01ce9...370be43. Read the comment docs.

@yousoph
Copy link
Member

yousoph commented May 25, 2022

/testenv up

@github-actions
Copy link
Contributor

@yousoph Ephemeral environment spinning up at http://18.237.178.236:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

stephenLYZ
stephenLYZ approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yousoph
Copy link
Member

yousoph commented May 25, 2022

Tested a bit on the ephemeral, looking good to me also

@stephenLYZ stephenLYZ merged commit 95b28fc into apache:master May 26, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request May 26, 2022
@prosdev0107 @sadpandajoe
fix(db): make to allow to show/hide the password when only creating (a…
20f2ebe 
…pache#20186)

(cherry picked from commit 95b28fc)
@sadpandajoe
Copy link
Member

🏷️ preset:2022.21

philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@prosdev0107 @philipher29
fix(db): make to allow to show/hide the password when only creating (a…
f6ad899 
…pache#20186)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegomedina248 diegomedina248 diegomedina248 approved these changes

@stephenLYZ stephenLYZ stephenLYZ approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.21 Preset-Patch size/XS 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@prosdev0107 @yousoph @sadpandajoe @stephenLYZ @diegomedina248 @mistercrunch